Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: thread watcher goroutine does not exit when closed #38090

Closed
1 task done
congqixia opened this issue Nov 29, 2024 · 0 comments · Fixed by #38091
Closed
1 task done

[Bug]: thread watcher goroutine does not exit when closed #38090

congqixia opened this issue Nov 29, 2024 · 0 comments · Fixed by #38091
Assignees
@congqixia
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: 5e15276
- Deployment mode(standalone or cluster): both
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

thread watcher goroutine does not exit when closed and it blocks pod exits

Expected Behavior

watcher shall quit normally

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@congqixia congqixia added kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Nov 29, 2024
@congqixia congqixia self-assigned this Nov 29, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Nov 29, 2024
@congqixia
fix: Return thread watcher goroutine after closed
acd1d9e 
Resolves milvus-io#38090

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Nov 29, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Nov 29, 2024
@congqixia
fix: Return thread watcher goroutine after closed
2c473e8 
Resolves milvus-io#38090

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Nov 29, 2024
@congqixia
fix: Return thread watcher goroutine after closed (milvus-io#38091)
9d68637 
Resolves milvus-io#38090

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Nov 29, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Dec 2, 2024
@congqixia
fix: [2.4] Return thread watcher goroutine after closed (#38091) (#38104
6a32b06 
)

Cherry-pick from master
pr: #38091 
Resolves #38090

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Return thread watcher goroutine after closed congqixia/milvus
1 participant
@congqixia