Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: grant Manual Compact API doesn't work #38086

Closed
1 task done
weiliu1031 opened this issue Nov 29, 2024 · 1 comment
Closed
1 task done

[Bug]: grant Manual Compact API doesn't work #38086

weiliu1031 opened this issue Nov 29, 2024 · 1 comment
Assignees
@weiliu1031
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
2.4.19

Comments

@weiliu1031
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: 2.4 and 2.5 and master
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

issue #38803 shows that grant manual compact api doesn't work, which caused by manual compact api pass collection id instead of collection name, which break the rbac constriant.

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response
@weiliu1031 weiliu1031 added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 29, 2024
@weiliu1031
Copy link
Contributor Author

/assign

This was referenced Nov 29, 2024
Merged
Merged
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 29, 2024
@yanliang567 yanliang567 added this to the 2.4.18 milestone Nov 29, 2024
@yanliang567 yanliang567 removed their assignment Nov 29, 2024
This was referenced Nov 29, 2024
Merged
Merged
sre-ci-robot pushed a commit to milvus-io/pymilvus that referenced this issue Dec 2, 2024
@weiliu1031
fix: grant ManualCompact api doesn't work (#2396)
88dfcb8 
issue: milvus-io/milvus#38086
cause RBAC require to check collection name, but ManualCompact rpc pass
collection id in request, so grant ManualCompact api doesn't work.

This PR refine compact api impl to pass collection name in request.

Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Dec 3, 2024
@weiliu1031
fix: grant ManualCompact api doesn't work (#38096)
e09f431 
issue: #38086
cause ManualCompact api pass collection id in request, but RBAC requires
to check collection name, so grant ManualCompact api doesn't work.

This PR refine the ManualCompact api to accpet collection name in
request.

Signed-off-by: Wei Liu <[email protected]>
weiliu1031 added a commit to weiliu1031/milvus that referenced this issue Dec 3, 2024
@weiliu1031
fix: grant ManualCompact api doesn't work (milvus-io#38096)
2450976 
issue: milvus-io#38086
cause ManualCompact api pass collection id in request, but RBAC requires
to check collection name, so grant ManualCompact api doesn't work.

This PR refine the ManualCompact api to accpet collection name in
request.

Signed-off-by: Wei Liu <[email protected]>
@weiliu1031 weiliu1031 mentioned this issue Dec 3, 2024
Merged
weiliu1031 added a commit to weiliu1031/milvus that referenced this issue Dec 3, 2024
@weiliu1031
fix: grant ManualCompact api doesn't work (milvus-io#38096)
283ea7d 
issue: milvus-io#38086
cause ManualCompact api pass collection id in request, but RBAC requires
to check collection name, so grant ManualCompact api doesn't work.

This PR refine the ManualCompact api to accpet collection name in
request.

Signed-off-by: Wei Liu <[email protected]>
weiliu1031 added a commit to weiliu1031/milvus that referenced this issue Dec 4, 2024
@weiliu1031
fix: grant ManualCompact api doesn't work (milvus-io#38096)
423dbd8 
issue: milvus-io#38086
cause ManualCompact api pass collection id in request, but RBAC requires
to check collection name, so grant ManualCompact api doesn't work.

This PR refine the ManualCompact api to accpet collection name in
request.

Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Dec 5, 2024
@weiliu1031
fix: grant ManualCompact api doesn't work (#38096) (#38168)
8646bba 
issue: #38086
pr: #38096
cause ManualCompact api pass collection id in request, but RBAC requires
to check collection name, so grant ManualCompact api doesn't work.

This PR refine the ManualCompact api to accpet collection name in
request.

Signed-off-by: Wei Liu <[email protected]>
weiliu1031 added a commit to weiliu1031/pymilvus that referenced this issue Dec 24, 2024
@weiliu1031
fix: grant ManualCompact api doesn't work (milvus-io#2396)
8bf3f52 
issue: milvus-io/milvus#38086
cause RBAC require to check collection name, but ManualCompact rpc pass
collection id in request, so grant ManualCompact api doesn't work.

This PR refine compact api impl to pass collection name in request.

Signed-off-by: Wei Liu <[email protected]>
@weiliu1031 weiliu1031 mentioned this issue Dec 24, 2024
Merged
weiliu1031 added a commit to weiliu1031/pymilvus that referenced this issue Dec 24, 2024
@weiliu1031
fix: grant ManualCompact api doesn't work (milvus-io#2396)
7edd2c1 
issue: milvus-io/milvus#38086
cause RBAC require to check collection name, but ManualCompact rpc pass
collection id in request, so grant ManualCompact api doesn't work.

This PR refine compact api impl to pass collection name in request.

Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot pushed a commit to milvus-io/pymilvus that referenced this issue Dec 24, 2024
@weiliu1031
fix: grant ManualCompact api doesn't work (#2396) (#2508)
0ccd878 
issue: milvus-io/milvus#38086
pr: #2396
cause RBAC require to check collection name, but ManualCompact rpc pass
collection id in request, so grant ManualCompact api doesn't work.

This PR refine compact api impl to pass collection name in request.

Signed-off-by: Wei Liu <[email protected]>
@weiliu1031 weiliu1031 mentioned this issue Dec 24, 2024
Merged
sre-ci-robot pushed a commit to milvus-io/pymilvus that referenced this issue Dec 24, 2024
@weiliu1031
fix: grant ManualCompact api doesn't work (#2396) (#2509)
6c326cf 
issue: milvus-io/milvus#38086
pr: #2396
cause RBAC require to check collection name, but ManualCompact rpc pass
collection id in request, so grant ManualCompact api doesn't work.

This PR refine compact api impl to pass collection name in request.

Signed-off-by: Wei Liu <[email protected]>
@yanliang567 yanliang567 modified the milestones: 2.4.18, 2.4.19 Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weiliu1031 weiliu1031

Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
2.4.19
Development

No branches or pull requests
2 participants
@yanliang567 @weiliu1031