Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bug for Search fails with filter expression contains underscore #38085

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Nov 29, 2024

Enhance the matching for elements within the UnaryRangeArray
#38068

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 29, 2024
Copy link
Contributor

mergify bot commented Nov 29, 2024

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Nov 29, 2024

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 29, 2024

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.08%. Comparing base (f211e99) to head (72b8350).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/exec/expression/UnaryExpr.h 0.00% 9 Missing ⚠️
internal/core/src/exec/expression/UnaryExpr.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #38085   +/-   ##
=======================================
  Coverage   81.07%   81.08%           
=======================================
  Files        1372     1372           
  Lines      191389   191401   +12     
=======================================
+ Hits       155173   155195   +22     
+ Misses      30719    30713    -6     
+ Partials     5497     5493    -4     
Components Coverage Δ
Client 74.43% <ø> (ø)
Core 68.84% <0.00%> (-0.04%) ⬇️
Go 83.20% <ø> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/exec/expression/UnaryExpr.cpp 84.36% <0.00%> (-0.59%) ⬇️
internal/core/src/exec/expression/UnaryExpr.h 68.88% <0.00%> (-7.66%) ⬇️

... and 32 files with indirect coverage changes

@xiaocai2333
Copy link
Contributor

/run-cpu-e2e

@xiaocai2333
Copy link
Contributor

rerun go-sdk

@xiaocai2333
Copy link
Contributor

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Dec 1, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, JsDove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaocai2333
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 6d0a4fd into milvus-io:master Dec 5, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants