Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check if the dynamic fields contain any static fields #38025

Merged
merged 1 commit into from
Dec 1, 2024
Merged

fix: Check if the dynamic fields contain any static fields #38025

merged 1 commit into from
Dec 1, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #38024

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 26, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 26, 2024
This was referenced Nov 26, 2024
Closed
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (9d3035c) to head (858abcd).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #38025   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files        1369     1369           
  Lines      190967   190965    -2     
=======================================
+ Hits       154799   154810   +11     
+ Misses      30680    30668   -12     
+ Partials     5488     5487    -1
Components Coverage Δ
Client 73.67% <ø> (ø)
Core 68.87% <ø> (ø)
Go 83.20% <100.00%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/util.go 90.18% <100.00%> (+0.05%) ⬆️
internal/proxy/validate_util.go 89.20% <ø> (-0.17%) ⬇️

... and 29 files with indirect coverage changes

@xiaocai2333
Copy link
Contributor Author

rerun cpp-unit-test

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun cpp-unit-test

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333 xiaocai2333 force-pushed the check_field_exist_dynamic branch from da9b39f to 7479133 Compare November 29, 2024 05:27
@xiaocai2333 xiaocai2333 force-pushed the check_field_exist_dynamic branch from 7479133 to 858abcd Compare November 29, 2024 05:32
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2024

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 29, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Nov 29, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 1, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2319018 into milvus-io:master Dec 1, 2024
20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 2, 2024
@xiaocai2333
fix: [2.4]Check if the dynamic fields contain any static fields (#38027)
580caeb 
issue: #38024 

master pr: #38025

Signed-off-by: Cai Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaocai2333 @czs007 @sre-ci-robot