Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: the actual number of databases should equal the config value #38006

Merged
merged 1 commit into from
Nov 29, 2024
Merged

enhance: the actual number of databases should equal the config value #38006

merged 1 commit into from
Nov 29, 2024

Conversation

jaime0815
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 25, 2024
This was referenced Nov 25, 2024
Merged
Merged
@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (8188e14) to head (57d39fa).
Report is 15 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38006       +/-   ##
===========================================
+ Coverage   68.87%   81.07%   +12.20%     
===========================================
  Files         289     1360     +1071     
  Lines       25484   190840   +165356     
===========================================
+ Hits        17551   154726   +137175     
- Misses       7933    30621    +22688     
- Partials        0     5493     +5493
Components Coverage Δ
Client 72.33% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.25% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/rootcoord/create_db_task.go 84.21% <100.00%> (ø)

... and 1070 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sre-ci-robot pushed a commit that referenced this pull request Nov 26, 2024
@jaime0815
enhance: the actual number of databases should equal the config value (…
797db3d 
…#38010)

pr: #38006

Signed-off-by: jaime <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Nov 26, 2024
@jaime0815
enhance: the actual number of databases should equal the config value (…
1c8f14e 
…#38009)

pr: #38006

Signed-off-by: jaime <[email protected]>
@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

2 similar comments
@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Nov 26, 2024
@jaime0815 jaime0815 force-pushed the max-db-algin-config-m branch from b59184b to 74cfe33 Compare November 27, 2024 03:59
@mergify mergify bot removed the ci-passed label Nov 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the max-db-algin-config-m branch from 74cfe33 to 4a933d3 Compare November 27, 2024 08:13
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Nov 27, 2024

/approve
/lgtm

@jaime0815 jaime0815 force-pushed the max-db-algin-config-m branch from 4a933d3 to 57d39fa Compare November 27, 2024 10:07
@sre-ci-robot sre-ci-robot removed the lgtm label Nov 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

4 similar comments
@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 28, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 29, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 29, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a9080d8 into milvus-io:master Nov 29, 2024
20 checks passed
@jaime0815 jaime0815 deleted the max-db-algin-config-m branch November 30, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@yhmo yhmo Awaiting requested review from yhmo

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaime0815 @czs007 @sre-ci-robot