Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Do not panic if a Rust function returns an error #37930

Open
1 task done
sunby opened this issue Nov 22, 2024 · 2 comments
Open
1 task done

[Enhancement]: Do not panic if a Rust function returns an error #37930

sunby opened this issue Nov 22, 2024 · 2 comments
Assignees
@sunby
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@sunby
Copy link
Contributor

sunby commented Nov 22, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Now we only call unwrap in Rust function and make system crash.
Maybe we can convert Rust error to a C++ struct and return to caller, then we can handle it in C++.

Why is this needed?

No response

Anything else?

No response
@sunby sunby added the kind/enhancement Issues or changes related to enhancement label Nov 22, 2024
@sunby
Copy link
Contributor Author

sunby commented Nov 25, 2024

/assign

@sunby sunby mentioned this issue Nov 25, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Nov 28, 2024
@sunby
enhance: optimize self defined rust error (#37975)
e6af806 
Prepare for issue: #37930

Signed-off-by: sunby <[email protected]>
@sunby sunby mentioned this issue Nov 30, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Dec 16, 2024
@sunby
enhance: Handle rust error in c++ (#38113)
3e2a2f2 
#37930

---------

Signed-off-by: sunby <[email protected]>
@stale Stale
Copy link

stale bot commented Dec 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunby sunby

Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sunby