Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: refactor bitmap index and internal hybrid index #34450

Merged
merged 1 commit into from
Jul 18, 2024
Merged

enhance: refactor bitmap index and internal hybrid index #34450

merged 1 commit into from
Jul 18, 2024

Conversation

zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Jul 5, 2024

@sre-ci-robot sre-ci-robot requested review from bigsheeper and czs007 July 5, 2024 08:49
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 5, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 5, 2024
@zhagnlu zhagnlu force-pushed the rename_bitmap_index branch from c175387 to ed0acbf Compare July 5, 2024 08:54
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 5, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the rename_bitmap_index branch from ed0acbf to 7e682fe Compare July 9, 2024 07:22
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jul 9, 2024
@zhagnlu zhagnlu force-pushed the rename_bitmap_index branch from 7e682fe to 3b4c681 Compare July 9, 2024 07:26
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 9, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the rename_bitmap_index branch 2 times, most recently from 81219c8 to f53f717 Compare July 9, 2024 08:16
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 9, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jul 9, 2024

rerun ut

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jul 9, 2024

/run-cpu-e2e

1 similar comment
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jul 9, 2024

/run-cpu-e2e

@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jul 10, 2024

rerun ut

@zhagnlu zhagnlu force-pushed the rename_bitmap_index branch from f53f717 to 12bbdad Compare July 10, 2024 06:16
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jul 11, 2024

rerun ut

@mergify mergify bot added the ci-passed label Jul 11, 2024
longjiquan
longjiquan reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@longjiquan longjiquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.78947% with 23 lines in your changes missing coverage. Please review.

Project coverage is 80.79%. Comparing base (3306bc2) to head (71a0863).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34450      +/-   ##
==========================================
+ Coverage   80.76%   80.79%   +0.02%     
==========================================
  Files        1161     1157       -4     
  Lines      141015   141421     +406     
==========================================
+ Hits       113892   114257     +365     
- Misses      22750    22789      +39     
- Partials     4373     4375       +2
Files Coverage Δ
internal/core/src/index/InvertedIndexTantivy.h 52.38% <ø> (ø)
internal/core/src/storage/DiskFileManagerImpl.h 77.77% <100.00%> (+11.11%) ⬆️
pkg/common/common.go 83.33% <ø> (ø)
pkg/util/indexparamcheck/bitmap_index_checker.go 86.66% <ø> (-13.34%) ⬇️
pkg/util/indexparamcheck/conf_adapter_mgr.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/hybrid_index_checker.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/index_type.go 100.00% <ø> (ø)
pkg/util/typeutil/schema.go 85.77% <100.00%> (+0.02%) ⬆️
internal/core/src/index/HybridScalarIndex.cpp 65.61% <66.66%> (-9.74%) ⬇️
internal/core/src/index/InvertedIndexTantivy.cpp 80.95% <92.85%> (+12.03%) ⬆️
... and 3 more

... and 228 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Jul 11, 2024 •
edited
Loading

@zhagnlu @xiaofan-luan We should discuss whether to expose the HybridIndex indextype to the outside or hide it under AutoIndex, while exposing the BitMap Index.

@czs007
Copy link
Collaborator

czs007 commented Jul 12, 2024

/hold

@zhagnlu zhagnlu force-pushed the rename_bitmap_index branch from 12bbdad to 64e45d6 Compare July 12, 2024 11:04
@zhagnlu zhagnlu force-pushed the rename_bitmap_index branch from 2c0a66e to 7ed9f86 Compare July 15, 2024 06:27
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 15, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the rename_bitmap_index branch from 7ed9f86 to 6b49755 Compare July 15, 2024 07:58
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Jul 15, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 15, 2024

⚠️ The sha of the head commit of this PR conflicts with #34586. Mergify cannot evaluate rules on this PR. ⚠️

@zhagnlu zhagnlu force-pushed the rename_bitmap_index branch from 6b49755 to 0f292e0 Compare July 15, 2024 08:27
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Jul 15, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 15, 2024

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhagnlu zhagnlu force-pushed the rename_bitmap_index branch 5 times, most recently from e319332 to a25d269 Compare July 16, 2024 06:46
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jul 16, 2024

rerun ut

1 similar comment
@zhagnlu
Copy link
Contributor Author

zhagnlu commented Jul 16, 2024

rerun ut

@zhagnlu zhagnlu force-pushed the rename_bitmap_index branch from a25d269 to 71a0863 Compare July 17, 2024 02:13
@mergify mergify bot added the ci-passed label Jul 17, 2024
@czs007
Copy link
Collaborator

czs007 commented Jul 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented Jul 18, 2024

/unhold

@sre-ci-robot sre-ci-robot merged commit f1b2f7b into milvus-io:master Jul 18, 2024
10 of 12 checks passed
@longjiquan longjiquan mentioned this pull request Jul 30, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Jul 30, 2024
@longjiquan @zhagnlu
fix: support auto index for array (#35095)
86edca8 
/kind branch-feature
pr: #34450

---------

Signed-off-by: longjiquan <[email protected]>
Co-authored-by: Zhagnlu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longjiquan longjiquan longjiquan left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@longjiquan longjiquan

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhagnlu @czs007 @sre-ci-robot @longjiquan