Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Conan version 1.58.0 can no longer install googleapis/cci.20221108 #27869

Closed
1 task done
ashkrisk opened this issue Oct 23, 2023 · 3 comments
Closed
1 task done
Assignees
Labels
area/compilation kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ashkrisk
Copy link
Contributor

ashkrisk commented Oct 23, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- OS: Ubuntu 20.04
- Linux/x86_64

Current Behavior

The workflow to compile Milvus on a fresh Ubuntu 20.04 machine no longer works.

From a clean Ubuntu 20.04 machine, first run scripts/install_deps.sh. Among other things, this installs Conan version 1.58.0.

Now, try to build Milvus locally with make. The build fails quickly because of the following error:

ERROR: googleapis/cci.20221108: Cannot load recipe.
(...) Current Conan version (1.58.0) does not satisfy the defined one (>=1.60.0 <2 || >=2.0.5).
conan install failed

Expected Behavior

On a clean install of Ubuntu 20.04, ./install_deps.sh followed by make should successfully build Milvus.

Steps To Reproduce

1. Clean install of Ubuntu 20.04 (x86_64)
2. Clone the milvus repository (this repository)
3. Install cmake and go
4. Run the install script `scripts/setup_deps.sh`
5. Run `make`
6. The build fails quickly with this error:

googleapis/cci.20221108: Not found in local cache, looking in remotes...
googleapis/cci.20221108: Trying with 'conancenter'...
Downloading conanmanifest.txt completed [0.31k]                                          
Downloading conanfile.py completed [10.38k]                                              
Downloading conan_export.tgz completed [2.53k]                                           
Decompressing conan_export.tgz completed [0.00k]                                         
googleapis/cci.20221108: Downloaded recipe revision bbf3991516a8b3ce0923209c3df92665
ERROR: googleapis/cci.20221108: Cannot load recipe.
Error loading conanfile at '/root/.conan/data/googleapis/cci.20221108/_/_/export/conanfile.py': Current Conan version (1.58.0) does not satisfy the defined one (>=1.60.0 <2 || >=2.0.5).
conan install failed

Anything else?

Possibly, the build was broken by this update to the googleapis/20221108 recipe: conan-io/conan-center-index#19971. As part of that PR, the required conan version was updated:

Screenshot 2023-10-23 at 10 06 34 PM

Updating the conan version to 1.60.0 is enough to resolve the issue

@ashkrisk ashkrisk added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 23, 2023
@jiaoew1991
Copy link
Contributor

we need to upgrade conan version 🤔

@yanliang567
Copy link
Contributor

/assign @jiaoew1991
/unassign

@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. area/compilation and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 24, 2023
Copy link

stale bot commented Nov 23, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Nov 23, 2023
sre-ci-robot pushed a commit that referenced this issue Mar 20, 2024
The conan version used in all the setup scripts was updated to `1.61.0`
in #27870. However, a line in
the developer documentation was left out.

Since the dependencies no longer install correctly with conan `1.58`
(#27869), all documentation
should consistently use the updated version.

Signed-off-by: Ashwin Krishna Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compilation kind/bug Issues or changes related a bug stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants