fix: Add defer Unpin when error happens (#36620)

Resolves: #36619 --------- Signed-off-by: Congqi Xia <[email protected]>
milvus-io · Sep 30, 2024 · ddc3e76 · ddc3e76
1 parent 2055df8
commit ddc3e76
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/internal/querynodev2/segments/validate.go b/internal/querynodev2/segments/validate.go
@@ -62,6 +62,11 @@ func validate(ctx context.Context, manager *Manager, collectionID int64, partiti
 	// validate segment
 	segments := make([]Segment, 0, len(segmentIDs))
 	var err error
+	defer func() {
+		if err != nil {
+			manager.Segment.Unpin(segments)
+		}
+	}()
 	if len(segmentIDs) == 0 {
 		for _, partID := range searchPartIDs {
 			segments, err = manager.Segment.GetAndPinBy(WithPartition(partID), segmentFilter)
@@ -76,7 +81,7 @@ func validate(ctx context.Context, manager *Manager, collectionID int64, partiti
 		}
 		for _, segment := range segments {
 			if !funcutil.SliceContain(searchPartIDs, segment.Partition()) {
-				err := fmt.Errorf("segment %d belongs to partition %d, which is not in %v", segment.ID(), segment.Partition(), searchPartIDs)
+				err = fmt.Errorf("segment %d belongs to partition %d, which is not in %v", segment.ID(), segment.Partition(), searchPartIDs)
 				return nil, err
 			}
 		}