Skip to content

Commit

Permalink
fix: Channel may be released after balance (#37862)
Browse files Browse the repository at this point in the history
issue: #37830
casue dist handler doesn't set channel's version, so if channel checker
try to dedup channel, it may release the new delegator after balance
finished.

this PR fix the way to set proper version for channel.

Signed-off-by: Wei Liu <[email protected]>
  • Loading branch information
weiliu1031 authored Nov 21, 2024
1 parent f3a36f8 commit b983ef9
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion internal/querycoordv2/dist/dist_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,11 @@ func (dh *distHandler) updateChannelsDistribution(resp *querypb.GetDataDistribut
Version: ch.GetVersion(),
}
} else {
channel = channelInfo.Clone()
channel = &meta.DmChannel{
VchannelInfo: channelInfo.VchannelInfo,
Node: resp.GetNodeID(),
Version: ch.GetVersion(),
}
}
updates = append(updates, channel)
}
Expand Down

0 comments on commit b983ef9

Please sign in to comment.