Skip to content

Commit

Permalink
fix: Remove not needed BlockAll call in SyncSegments (#28632)
Browse files Browse the repository at this point in the history
See also #28628
Previous compaction task blocked the segment sync task and may block the
flowgraph when sync task is generated by auto sync policy This
`BlockAll` call will block forever and cause whole fg stuck

Signed-off-by: Congqi Xia <[email protected]>
  • Loading branch information
congqixia authored Nov 22, 2023
1 parent ca42cbd commit af18aa7
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions internal/datanode/services.go
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,6 @@ func (node *DataNode) SyncSegments(ctx context.Context, req *datapb.SyncSegments
return merr.Status(err), nil
}
bfs := metacache.NewBloomFilterSet(pks...)
ds.fg.Blockall()
defer ds.fg.Unblock()
ds.metacache.CompactSegments(req.GetCompactedTo(), req.GetPartitionId(), req.GetNumOfRows(), bfs, req.GetCompactedFrom()...)
node.compactionExecutor.injectDone(req.GetPlanID(), true)
return merr.Success(), nil
Expand Down

0 comments on commit af18aa7

Please sign in to comment.