-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Add levelzero compaction in DN (#28470)
See also: #27606 --------- Signed-off-by: yangxuan <[email protected]>
- Loading branch information
1 parent
d694405
commit aae7e62
Showing
14 changed files
with
1,215 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| // Licensed to the LF AI & Data foundation under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package io | ||
|
|
||
| import ( | ||
| "context" | ||
| "path" | ||
|
|
||
| "github.com/milvus-io/milvus/internal/storage" | ||
| "github.com/milvus-io/milvus/pkg/util/conc" | ||
| "github.com/milvus-io/milvus/pkg/util/retry" | ||
| ) | ||
|
|
||
| type BinlogIO interface { | ||
| Download(ctx context.Context, paths []string) ([][]byte, error) | ||
| Upload(ctx context.Context, kvs map[string][]byte) error | ||
| // JoinFullPath returns the full path by join the paths with the chunkmanager's rootpath | ||
| JoinFullPath(paths ...string) string | ||
| } | ||
|
|
||
| type BinlogIoImpl struct { | ||
| storage.ChunkManager | ||
| pool *conc.Pool[any] | ||
| } | ||
|
|
||
| func NewBinlogIO(cm storage.ChunkManager, ioPool *conc.Pool[any]) BinlogIO { | ||
| return &BinlogIoImpl{cm, ioPool} | ||
| } | ||
|
|
||
| func (b *BinlogIoImpl) Download(ctx context.Context, paths []string) ([][]byte, error) { | ||
| future := b.pool.Submit(func() (any, error) { | ||
| var vs [][]byte | ||
| var err error | ||
|
|
||
| err = retry.Do(ctx, func() error { | ||
| vs, err = b.MultiRead(ctx, paths) | ||
| return err | ||
| }) | ||
|
|
||
| return vs, err | ||
| }) | ||
|
|
||
| vs, err := future.Await() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return vs.([][]byte), nil | ||
| } | ||
|
|
||
| func (b *BinlogIoImpl) Upload(ctx context.Context, kvs map[string][]byte) error { | ||
| future := b.pool.Submit(func() (any, error) { | ||
| err := retry.Do(ctx, func() error { | ||
| return b.MultiWrite(ctx, kvs) | ||
| }) | ||
|
|
||
| return nil, err | ||
| }) | ||
|
|
||
| _, err := future.Await() | ||
| return err | ||
| } | ||
|
|
||
| func (b *BinlogIoImpl) JoinFullPath(paths ...string) string { | ||
| return path.Join(b.ChunkManager.RootPath(), path.Join(paths...)) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| package io | ||
|
|
||
| import ( | ||
| "path" | ||
| "testing" | ||
|
|
||
| "github.com/samber/lo" | ||
| "github.com/stretchr/testify/suite" | ||
| "golang.org/x/net/context" | ||
|
|
||
| "github.com/milvus-io/milvus/internal/storage" | ||
| "github.com/milvus-io/milvus/pkg/util/conc" | ||
| ) | ||
|
|
||
| const binlogIOTestDir = "/tmp/milvus_test/binlog_io" | ||
|
|
||
| func TestBinlogIO(t *testing.T) { | ||
| suite.Run(t, new(BinlogIOSuite)) | ||
| } | ||
|
|
||
| type BinlogIOSuite struct { | ||
| suite.Suite | ||
|
|
||
| cm storage.ChunkManager | ||
| b BinlogIO | ||
| } | ||
|
|
||
| func (s *BinlogIOSuite) SetupTest() { | ||
| pool := conc.NewDefaultPool[any]() | ||
|
|
||
| s.cm = storage.NewLocalChunkManager(storage.RootPath(binlogIOTestDir)) | ||
|
|
||
| s.b = NewBinlogIO(s.cm, pool) | ||
| } | ||
|
|
||
| func (s *BinlogIOSuite) TeardownTest() { | ||
| ctx := context.Background() | ||
| s.cm.RemoveWithPrefix(ctx, s.cm.RootPath()) | ||
| } | ||
|
|
||
| func (s *BinlogIOSuite) TestUploadDownload() { | ||
| kvs := map[string][]byte{ | ||
| path.Join(binlogIOTestDir, "a/b/c"): {1, 255, 255}, | ||
| path.Join(binlogIOTestDir, "a/b/d"): {1, 255, 255}, | ||
| } | ||
|
|
||
| ctx := context.Background() | ||
| err := s.b.Upload(ctx, kvs) | ||
| s.NoError(err) | ||
|
|
||
| vs, err := s.b.Download(ctx, lo.Keys(kvs)) | ||
| s.NoError(err) | ||
| s.ElementsMatch(lo.Values(kvs), vs) | ||
| } | ||
|
|
||
| func (s *BinlogIOSuite) TestJoinFullPath() { | ||
| tests := []struct { | ||
| description string | ||
| inPaths []string | ||
| outPath string | ||
| }{ | ||
| {"no input", nil, path.Join(binlogIOTestDir)}, | ||
| {"input one", []string{"a"}, path.Join(binlogIOTestDir, "a")}, | ||
| {"input two", []string{"a", "b"}, path.Join(binlogIOTestDir, "a/b")}, | ||
| } | ||
|
|
||
| for _, test := range tests { | ||
| s.Run(test.description, func() { | ||
| out := s.b.JoinFullPath(test.inPaths...) | ||
| s.Equal(test.outPath, out) | ||
| }) | ||
| } | ||
| } |
Oops, something went wrong.