Skip to content

Commit

Permalink
fix:[2.4]GrowingDataGetter get the wrong string data
Browse files Browse the repository at this point in the history
Signed-off-by: cqy123456 <[email protected]>
  • Loading branch information
cqy123456 committed Nov 26, 2024
1 parent cf1c423 commit 7e4677d
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion internal/core/src/query/GroupByOperator.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,11 @@ class GrowingDataGetter : public DataGetter<T> {

T
Get(int64_t idx) const {
return growing_raw_data_->operator[](idx);
if constexpr (std::is_same_v<std::string, T>) {
return T(growing_raw_data_->view_element(idx));

Check warning on line 54 in internal/core/src/query/GroupByOperator.h

View check run for this annotation

Codecov / codecov/patch

internal/core/src/query/GroupByOperator.h#L54

Added line #L54 was not covered by tests
} else {
return growing_raw_data_->operator[](idx);

Check warning on line 56 in internal/core/src/query/GroupByOperator.h

View check run for this annotation

Codecov / codecov/patch

internal/core/src/query/GroupByOperator.h#L56

Added line #L56 was not covered by tests
}
}
};

Expand Down

0 comments on commit 7e4677d

Please sign in to comment.