fix: nil pointer in health check request (#38266)

issue: #35563 pr: #35589 Signed-off-by: jaime <[email protected]>
milvus-io · Dec 6, 2024 · 51eb254 · 51eb254
1 parent 075b62e
commit 51eb254
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/datacoord/session_manager.go b/internal/datacoord/session_manager.go
@@ -538,7 +538,7 @@ func (c *SessionManagerImpl) CheckDNHealth(ctx context.Context) *healthcheck.Res
 				return
 			}
 
-			if len(checkHealthResp.Reasons) > 0 {
+			if checkHealthResp != nil && len(checkHealthResp.Reasons) > 0 {
 				wlock.Lock()
 				result.AppendResult(healthcheck.GetHealthCheckResultFromResp(checkHealthResp))
 				wlock.Unlock()

diff --git a/internal/querycoordv2/services.go b/internal/querycoordv2/services.go
@@ -1001,7 +1001,7 @@ func (s *Server) broadcastCheckHealth(ctx context.Context) *healthcheck.Result {
 				return
 			}
 
-			if len(checkHealthResp.Reasons) > 0 {
+			if checkHealthResp != nil && len(checkHealthResp.Reasons) > 0 {
 				wlock.Lock()
 				result.AppendResult(healthcheck.GetHealthCheckResultFromResp(checkHealthResp))
 				wlock.Unlock()