enhance: Add more info in logs (#36731)

Signed-off-by: yangxuan <[email protected]>
milvus-io · Oct 10, 2024 · 290ceb4 · 290ceb4
1 parent a5f98e4
commit 290ceb4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/internal/datanode/channel/channel_manager.go b/internal/datanode/channel/channel_manager.go
@@ -90,7 +90,7 @@ func NewChannelManager(pipelineParams *util.PipelineParams, fgManager pipeline.F
 func (m *ChannelManagerImpl) Submit(info *datapb.ChannelWatchInfo) error {
 	channel := info.GetVchan().GetChannelName()
 
-	// skip enqueue datacoord re-submit the same operations
+	// skip enqueue the same operation resubmmited by datacoord
 	if runner, ok := m.opRunners.Get(channel); ok {
 		if _, exists := runner.Exist(info.GetOpID()); exists {
 			log.Warn("op already exist, skip", zap.Int64("opID", info.GetOpID()), zap.String("channel", channel))
@@ -400,7 +400,7 @@ func (r *opRunner) watchWithTimer(info *datapb.ChannelWatchInfo) *opState {
 				return
 
 			case <-tickler.GetProgressSig():
-				log.Info("Reset timer for tickler updated")
+				log.Info("Reset timer for tickler updated", zap.Int32("current progress", tickler.Progress()))
 				timer.Reset(watchTimeout)
 
 			case <-successSig:

diff --git a/internal/datanode/compaction/mix_compactor.go b/internal/datanode/compaction/mix_compactor.go
@@ -115,9 +115,10 @@ func (t *mixCompactionTask) preCompact() error {
 	outputSegmentCount := int64(math.Ceil(float64(currSize) / float64(t.targetSize)))
 	log.Info("preCompaction analyze",
 		zap.Int64("planID", t.GetPlanID()),
-		zap.Int64("currSize", currSize),
+		zap.Int64("inputSize", currSize),
 		zap.Int64("targetSize", t.targetSize),
-		zap.Int64("estimatedSegmentCount", outputSegmentCount),
+		zap.Int("inputSegmentCount", len(t.plan.GetSegmentBinlogs())),
+		zap.Int64("estimatedOutputSegmentCount", outputSegmentCount),
 	)
 
 	return nil