enhance: Support collection name for ProxyDeleteVectors as well

Signed-off-by: Reid Chan <[email protected]>
milvus-io · Dec 5, 2024 · 13692fb · 13692fb
1 parent 051bc28
commit 13692fb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/internal/proxy/task_delete.go b/internal/proxy/task_delete.go
@@ -188,7 +188,11 @@ func (dt *deleteTask) Execute(ctx context.Context) (err error) {
 }
 
 func (dt *deleteTask) PostExecute(ctx context.Context) error {
-	metrics.ProxyDeleteVectors.WithLabelValues(paramtable.GetStringNodeID(), dt.req.GetDbName()).Add(float64(dt.count))
+	metrics.ProxyDeleteVectors.WithLabelValues(
+		paramtable.GetStringNodeID(),
+		dt.req.GetDbName(),
+		dt.req.GetCollectionName(),
+	).Add(float64(dt.count))
 	return nil
 }
 

diff --git a/pkg/metrics/proxy_metrics.go b/pkg/metrics/proxy_metrics.go
@@ -66,7 +66,7 @@ var (
 			Subsystem: typeutil.ProxyRole,
 			Name:      "delete_vectors_count",
 			Help:      "counter of vectors successfully deleted",
-		}, []string{nodeIDLabelName, databaseLabelName})
+		}, []string{nodeIDLabelName, databaseLabelName, collectionName})
 
 	// ProxySQLatency record the latency of search successfully.
 	ProxySQLatency = prometheus.NewHistogramVec(