feat(TLS): Support skipCertCheck option to bypass certificate check #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zander-bobronnikov
force-pushed
the
feat/support-unauthorized-tls-mode-for-main-repo
branch
2 times, most recently
from
6ce207d to
1f48880
Compare
This option allows for connecting to Milvus instances with self-signed certificates, without the need to pass the certificate Signed-off-by: Zander Bobronnikov <[email protected]>
zander-bobronnikov
force-pushed
the
feat/support-unauthorized-tls-mode-for-main-repo
branch
from
1f48880 to
9d07446
Compare
shanghaikid
approved these changes
Nov 6, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shanghaikid, zander-bobronnikov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This will be released util milvus 2.5. I guess in 1 or two weeks. |
shanghaikid
pushed a commit
that referenced
this pull request
Dec 16, 2024
…370) This option allows for connecting to Milvus instances with self-signed certificates, without the need to pass the certificate Signed-off-by: Zander Bobronnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new
skipCertCheckoption allows for connecting to Milvus instances with self-signed certificates, without the need to pass the certificate directly.Signed-off-by: Zander Bobronnikov [email protected]