Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle empty array search/query result #257

Merged
merged 2 commits into from
Nov 14, 2023
Merged

handle empty array search/query result #257

merged 2 commits into from
Nov 14, 2023

Conversation

shanghaikid
Copy link
Contributor

In this pr, it fixes that the search/query will be failed if the data contains empty array.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (5d805b9) 95.57% compared to head (a0e75b3) 95.15%.
Report is 3 commits behind head on main.

❗ Current head a0e75b3 differs from pull request most recent head 4edbc18. Consider uploading reports for the commit 4edbc18 to get more accurate results

Files Patch % Lines
milvus/HttpClient.ts 75.67% 9 Missing ⚠️
milvus/http/Vector.ts 46.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
- Coverage   95.57%   95.15%   -0.43%     
==========================================
  Files          37       39       +2     
  Lines        1742     1838      +96     
  Branches      453      436      -17     
==========================================
+ Hits         1665     1749      +84     
- Misses         70       86      +16     
+ Partials        7        3       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nameczz, shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nameczz nameczz merged commit f9cc13c into main Nov 14, 2023
2 of 3 checks passed
@nameczz nameczz deleted the array branch November 14, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants