Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client id #251

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Add client id #251

merged 3 commits into from
Oct 20, 2023

Conversation

shanghaikid
Copy link
Contributor

In this pr,

it will add a uuid as the client id after client creation, user is able to change it by passing clientId in the clientConfig, for example:

const milvusClient = new MilvusClient({
  address: IP,
  id: '1',
});

and we will also modify the debug log format with the client id:

[2023-10-20T03:45:20.902Z] Milvus-sdk-node debug: [ac19aabc-b7ab-43de-8567-351d3f39245e>default>Connect] executed in 132ms, ...

Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #251 (0c25aa9) into main (02dfdf1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 0c25aa9 differs from pull request most recent head 2e2aac3. Consider uploading reports for the commit 2e2aac3 to get more accurate results

@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   95.73%   95.74%   +0.01%     
==========================================
  Files          33       33              
  Lines        1665     1669       +4     
  Branches      407      442      +35     
==========================================
+ Hits         1594     1598       +4     
+ Misses         68       64       -4     
- Partials        3        7       +4     
Files Coverage Δ
milvus/grpc/BaseClient.ts 77.96% <100.00%> (+1.60%) ⬆️
milvus/grpc/GrpcClient.ts 70.66% <ø> (ø)
milvus/utils/Grpc.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nameczz nameczz merged commit 54e98cd into main Oct 20, 2023
2 checks passed
@nameczz nameczz deleted the client branch October 20, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants