Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [2.4] optional db for grant/revoke v2 #856

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: [2.4] optional db for grant/revoke v2 #856

merged 1 commit into from
Dec 10, 2024

Conversation

shaoting-huang
Copy link
Contributor

cherry-pick from master: #852
issue: milvus-io/milvus#37031

@shaoting-huang
optional db for grant/revoke v2
e445a1b 
Signed-off-by: shaoting-huang <[email protected]>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 10, 2024
@mergify mergify bot added the ci-passed auto merge needed label label Dec 10, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v2.4.x@48cb4a2). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             v2.4.x   #856   +/-   ##
=======================================
  Coverage          ?      0           
=======================================
  Files             ?      0           
  Lines             ?      0           
  Branches          ?      0           
=======================================
  Hits              ?      0           
  Misses            ?      0           
  Partials          ?      0

@congqixia
Copy link
Contributor

/kind enhancmenet

@sre-ci-robot
Copy link

@congqixia: The label(s) kind/enhancmenet cannot be applied, because the repository doesn't have them.

In response to this:

/kind enhancmenet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@congqixia
Copy link
Contributor

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Dec 10, 2024
congqixia
congqixia approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Dec 10, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Dec 10, 2024
@sre-ci-robot sre-ci-robot merged commit d724dc8 into milvus-io:v2.4.x Dec 10, 2024
7 checks passed
@shaoting-huang shaoting-huang mentioned this pull request Dec 10, 2024
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

Assignees

@congqixia congqixia

Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaoting-huang @congqixia @sre-ci-robot