Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RestoreRBAC pass wrong role info of user #840

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: RestoreRBAC pass wrong role info of user #840

merged 1 commit into from
Oct 30, 2024

Conversation

weiliu1031
Copy link
Contributor

pr: #839

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 30, 2024
@weiliu1031
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed auto merge needed label label Oct 30, 2024
@congqixia
Copy link
Contributor

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Something isn't working label Oct 30, 2024
congqixia
congqixia approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Oct 30, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Oct 30, 2024
@sre-ci-robot sre-ci-robot merged commit d96fa32 into milvus-io:v2.4.x Oct 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

Assignees

@congqixia congqixia

Labels
approved review approved ci-passed auto merge needed label kind/bug Something isn't working lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiliu1031 @congqixia @sre-ci-robot