Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compose empty resultset for result count = 1 #731

Closed

Conversation

congqixia
Copy link
Contributor

See also #725

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 April 18, 2024 03:14
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/L Denotes a PR that changes 100-499 lines. labels Apr 18, 2024
@congqixia
Copy link
Contributor Author

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Something isn't working label Apr 18, 2024
@sre-ci-robot
Copy link

@congqixia: The label(s) kind/ cannot be applied, because the repository doesn't have them.

In response to this:

/kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@congqixia congqixia force-pushed the fix/compose_empty_resultset branch from 3267d02 to 85c7cef Compare April 18, 2024 06:05
@congqixia congqixia closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved kind/bug Something isn't working size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants