Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hybrid search case and response check #706

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Fix hybrid search case and response check #706

merged 2 commits into from
Apr 11, 2024

Conversation

congqixia
Copy link
Contributor

  • nq = 1 case fails due to milvus beavior change
  • check error not nil before check msg

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 April 10, 2024 09:54
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/XS Denotes a PR that changes 0-9 lines. labels Apr 10, 2024
@congqixia
Fix range filter error msg
1eb6378 
Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Apr 11, 2024
@mergify mergify bot added ci-passed auto merge needed label test/ci intergration test labels Apr 11, 2024
@ThreadDao
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Apr 11, 2024
@sre-ci-robot sre-ci-robot merged commit c32ae77 into milvus-io:master Apr 11, 2024
6 checks passed
@congqixia congqixia deleted the fix/hybrid_nq_resp_err branch April 11, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunby sunby Awaiting requested review from sunby

@yah01 yah01 Awaiting requested review from yah01

Assignees

@ThreadDao ThreadDao

Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/S Denotes a PR that changes 10-29 lines. test/ci intergration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @ThreadDao