Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass index type for Scalar indexes #696

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

congqixia
Copy link
Contributor

Related to #694 #695

@congqixia
Copy link
Contributor Author

/kind bug

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 April 3, 2024 07:53
@sre-ci-robot sre-ci-robot added approved review approved kind/bug Something isn't working size/S Denotes a PR that changes 10-29 lines. labels Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.93%. Comparing base (7d66951) to head (940e853).
Report is 2 commits behind head on master.

❗ Current head 940e853 differs from pull request most recent head 270cde5. Consider uploading reports for the commit 270cde5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
+ Coverage   71.90%   71.93%   +0.03%     
==========================================
  Files          51       51              
  Lines        4751     4754       +3     
==========================================
+ Hits         3416     3420       +4     
+ Misses       1211     1210       -1     
  Partials      124      124              
Files Coverage Δ
entity/index_scalar.go 100.00% <100.00%> (+14.28%) ⬆️

@congqixia congqixia force-pushed the fix/scalar_idx_pass_type branch from 940e853 to 270cde5 Compare April 8, 2024 08:56
@mergify mergify bot added the ci-passed auto merge needed label label Apr 8, 2024
@ThreadDao
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Apr 8, 2024
@sre-ci-robot sre-ci-robot merged commit 6bb1f79 into milvus-io:master Apr 8, 2024
7 checks passed
@congqixia congqixia deleted the fix/scalar_idx_pass_type branch April 11, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/bug Something isn't working lgtm look good to me size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants