Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Support Sparse Embedding #684

Merged

Conversation

congqixia
Copy link
Contributor

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 March 20, 2024 15:28
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/L Denotes a PR that changes 100-499 lines. labels Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 69.38776% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 71.89%. Comparing base (ffd629b) to head (37ca3e3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
- Coverage   71.95%   71.89%   -0.06%     
==========================================
  Files          50       51       +1     
  Lines        4649     4746      +97     
==========================================
+ Hits         3345     3412      +67     
- Misses       1183     1212      +29     
- Partials      121      122       +1     
Files Coverage Δ
entity/schema.go 91.79% <ø> (ø)
client/insert.go 78.47% <33.33%> (-1.53%) ⬇️
entity/columns_sparse.go 86.66% <86.66%> (ø)
entity/columns.go 46.66% <0.00%> (-2.07%) ⬇️

@mergify mergify bot added the ci-passed auto merge needed label label Mar 20, 2024
@congqixia
Copy link
Contributor Author

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Mar 21, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Mar 22, 2024
@sre-ci-robot sre-ci-robot merged commit 7ab04e8 into milvus-io:master Mar 22, 2024
7 checks passed
@congqixia congqixia deleted the enhance/support_sparse_embedding branch April 11, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants