Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Bump milvus-proto/go-api to v2.4.0-rc.1 #682

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

congqixia
Copy link
Contributor

Sync proto version to v2.4.0-rc.1 to support new features

Sync proto version to v2.4.0-rc.1 to support new features

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 March 20, 2024 13:17
@sre-ci-robot sre-ci-robot added approved review approved size/M Denotes a PR that changes 30-99 lines. labels Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.95%. Comparing base (8b5ef11) to head (64a2d33).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #682   +/-   ##
=======================================
  Coverage   71.95%   71.95%           
=======================================
  Files          50       50           
  Lines        4649     4649           
=======================================
  Hits         3345     3345           
  Misses       1183     1183           
  Partials      121      121           

Signed-off-by: Congqi Xia <[email protected]>
@congqixia
Copy link
Contributor Author

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Mar 20, 2024
@mergify mergify bot added the ci-passed auto merge needed label label Mar 20, 2024
@ThreadDao
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Mar 20, 2024
@sre-ci-robot sre-ci-robot merged commit 00e74ab into milvus-io:master Mar 20, 2024
7 checks passed
@congqixia congqixia deleted the bump_milvus_2.4.0-rc.1 branch April 11, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants