Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip TestSearchGroupByFloatDefault case #680

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

congqixia
Copy link
Contributor

TestSearchGroupByFloatDefault may fail randomly since hitrate maybe lower than 0.2, which is reasonable due to index variable.

`TestSearchGroupByFloatDefault` may fail randomly since hitrate maybe
lower than 0.2, which is reasonable due to index variable.

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 March 20, 2024 02:13
@sre-ci-robot sre-ci-robot added approved review approved size/XS Denotes a PR that changes 0-9 lines. labels Mar 20, 2024
@congqixia
Copy link
Contributor Author

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Mar 20, 2024
Signed-off-by: Congqi Xia <[email protected]>
@mergify mergify bot added ci-passed auto merge needed label test/ci intergration test labels Mar 20, 2024
@congqixia congqixia changed the title fix: Lower group by hit rate to make case stable fix: Skip TestSearchGroupByFloatDefault case Mar 20, 2024
@ThreadDao
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Mar 20, 2024
@sre-ci-robot sre-ci-robot merged commit efe391f into milvus-io:master Mar 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/XS Denotes a PR that changes 0-9 lines. test/ci intergration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants