Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Cherry-pick] deduce AutoID from field info #656

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

congqixia
Copy link
Contributor

cherry pick from master
pr: #655
Resolves: #654

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 January 17, 2024 04:51
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/XS Denotes a PR that changes 0-9 lines. labels Jan 17, 2024
@congqixia
Copy link
Contributor Author

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Something isn't working label Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5ed4388) 73.26% compared to head (bd3dc77) 73.22%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           v2.3.x     #656      +/-   ##
==========================================
- Coverage   73.26%   73.22%   -0.05%     
==========================================
  Files          46       46              
  Lines        4200     4201       +1     
==========================================
- Hits         3077     3076       -1     
- Misses       1022     1023       +1     
- Partials      101      102       +1     
Files Coverage Δ
entity/schema.go 90.21% <0.00%> (-1.04%) ⬇️

@mergify mergify bot added the ci-passed auto merge needed label label Jan 17, 2024
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jan 17, 2024
@sre-ci-robot sre-ci-robot merged commit 01a80f0 into milvus-io:v2.3.x Jan 17, 2024
7 checks passed
@congqixia congqixia deleted the cp_655 branch February 20, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/bug Something isn't working lgtm look good to me size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants