Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Bump proto & SDK version to v2.3.4 #644

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

congqixia
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 December 29, 2023 12:30
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/XS Denotes a PR that changes 0-9 lines. labels Dec 29, 2023
Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Dec 29, 2023
@mergify mergify bot added the ci-passed auto merge needed label label Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v2.3.x@4f21564). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             v2.3.x     #644   +/-   ##
=========================================
  Coverage          ?   74.95%           
=========================================
  Files             ?       44           
  Lines             ?     4125           
  Branches          ?        0           
=========================================
  Hits              ?     3092           
  Misses            ?      921           
  Partials          ?      112           

@congqixia
Copy link
Contributor Author

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Dec 29, 2023
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Dec 29, 2023
@sre-ci-robot sre-ci-robot merged commit 9e1483c into milvus-io:v2.3.x Dec 29, 2023
7 checks passed
@congqixia congqixia deleted the bump_proto_v2.3.4 branch February 20, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants