Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support alter index #634

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Dec 6, 2023

support to enable/disable index mmap mode by altering index

@sre-ci-robot sre-ci-robot added approved review approved size/L Denotes a PR that changes 100-499 lines. labels Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (abdee17) 73.29% compared to head (bf7ac34) 73.26%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
- Coverage   73.29%   73.26%   -0.03%     
==========================================
  Files          46       46              
  Lines        4272     4290      +18     
==========================================
+ Hits         3131     3143      +12     
- Misses       1028     1034       +6     
  Partials      113      113              
Files Coverage Δ
client/index.go 76.87% <66.66%> (-1.43%) ⬇️

@mergify mergify bot added the ci-passed auto merge needed label label Dec 6, 2023
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Jan 5, 2024
@mergify mergify bot removed the ci-passed auto merge needed label label Jan 5, 2024
support to enable/disable index mmap mode by altering index

Signed-off-by: yah01 <[email protected]>
@mergify mergify bot added the ci-passed auto merge needed label label Jan 5, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jan 5, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5c2414c into milvus-io:master Jan 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants