Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the typo error for the WithReleasePartitionMsgBase option #626

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Nov 14, 2023

No description provided.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #626 (28c392d) into master (17be3e5) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
- Coverage   74.97%   74.95%   -0.02%     
==========================================
  Files          44       44              
  Lines        4124     4125       +1     
==========================================
  Hits         3092     3092              
- Misses        920      921       +1     
  Partials      112      112              
Files Coverage Δ
client/options_msg_base.go 96.00% <0.00%> (-4.00%) ⬇️

@mergify mergify bot added the ci-passed auto merge needed label label Nov 14, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Nov 14, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Nov 14, 2023
@congqixia
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Nov 14, 2023
@sre-ci-robot sre-ci-robot merged commit d1df1d6 into milvus-io:master Nov 14, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants