Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version & make Collection Option EnableDynamicSchema work #625

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

congqixia
Copy link
Contributor

Bump proto version to v2.3.3 and change go sdk verison

Also make create collection enable dynamic schema work

@sre-ci-robot sre-ci-robot requested a review from sunby November 10, 2023 13:16
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested a review from yah01 November 10, 2023 13:16
@sre-ci-robot sre-ci-robot added the approved review approved label Nov 10, 2023
@congqixia
Copy link
Contributor Author

/kind bug
/kind improvement

@sre-ci-robot sre-ci-robot added kind/bug Something isn't working size/XS Denotes a PR that changes 0-9 lines. kind/improvement Changes related to something improve, likes ut and code refactor labels Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #625 (8d4945f) into master (087d17c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 8d4945f differs from pull request most recent head f0741be. Consider uploading reports for the commit f0741be to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
+ Coverage   74.96%   74.97%   +0.01%     
==========================================
  Files          44       44              
  Lines        4122     4124       +2     
==========================================
+ Hits         3090     3092       +2     
  Misses        920      920              
  Partials      112      112              
Files Coverage Δ
client/collection.go 88.75% <100.00%> (+0.06%) ⬆️

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Nov 10, 2023
Bump proto version to v2.3.3 and change go sdk verison

Also make create collection enable dynamic schema work

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed lgtm look good to me size/XS Denotes a PR that changes 0-9 lines. labels Nov 10, 2023
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Nov 10, 2023
@mergify mergify bot added the ci-passed auto merge needed label label Nov 10, 2023
@sre-ci-robot sre-ci-robot merged commit 17be3e5 into milvus-io:master Nov 10, 2023
6 checks passed
@congqixia congqixia deleted the bump_coll_opt branch February 20, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/bug Something isn't working kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants