Parse result field data when result set entry count is not zero #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since empty field data has no info for fieldName nor field type it's more meaningful to skip parse field data for empty resultSet This PR adds ResultCount check before performing fieldData parsing When resultSet is empty, the entry shall have no error with empty fields See also milvus-io#623 Signed-off-by: Congqi Xia <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind bug |
sre-ci-robot
added
kind/bug
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
=======================================
Coverage 74.60% 74.60%
=======================================
Files 42 42
Lines 4063 4064 +1
=======================================
+ Hits 3031 3032 +1
Misses 920 920
Partials 112 112
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since empty field data has no info for field name nor field type
it's more meaningful to skip parse field data for empty resultSet
This PR adds ResultCount check before performing fieldData parsing
When resultSet is empty, the entry shall have no error with empty fields
See also #623