Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamic field $meta not in result set if using wildcard #618

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fix dynamic field $meta not in result set if using wildcard #618

merged 1 commit into from
Nov 8, 2023

Conversation

congqixia
Copy link
Contributor

@congqixia congqixia commented Nov 8, 2023 •
edited
Loading

See also #596
/kind bug

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 November 8, 2023 10:01
@sre-ci-robot sre-ci-robot added approved review approved size/S Denotes a PR that changes 10-29 lines. labels Nov 8, 2023
@congqixia
Copy link
Contributor Author

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Something isn't working label Nov 8, 2023
yah01
yah01 reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Nov 8, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2023 •
edited
Loading

Codecov Report

Merging #618 (50102fc) into master (ed14896) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   75.14%   75.15%           
=======================================
  Files          41       41           
  Lines        4032     4033    +1     
=======================================
+ Hits         3030     3031    +1     
  Misses        890      890           
  Partials      112      112
Files Coverage Δ
client/data.go 70.47% <100.00%> (+0.08%) ⬆️

@congqixia congqixia force-pushed the fix_dynamic_field_wildcard branch from 2b46ba5 to 50102fc Compare November 8, 2023 12:29
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed lgtm look good to me size/S Denotes a PR that changes 10-29 lines. labels Nov 8, 2023
@mergify mergify bot added the ci-passed auto merge needed label label Nov 8, 2023
yah01
yah01 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Nov 8, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 40a4e1e into milvus-io:master Nov 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yah01 yah01 yah01 approved these changes

@sunby sunby Awaiting requested review from sunby

Assignees

@yah01 yah01

Labels
approved review approved ci-passed auto merge needed label kind/bug Something isn't working lgtm look good to me size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @yah01