Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Array datatype #607

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

congqixia
Copy link
Contributor

See also milvus-io/milvus#27168
/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Oct 25, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 October 25, 2023 13:37
@sre-ci-robot sre-ci-robot added approved review approved size/XXL Denotes a PR that changes 1000+ lines. labels Oct 25, 2023
@congqixia congqixia force-pushed the support_datatype_array branch from d3c44b4 to 0f46fb6 Compare October 25, 2023 15:14
Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia force-pushed the support_datatype_array branch from 0f46fb6 to 8448e1a Compare October 25, 2023 15:23
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #607 (8448e1a) into master (be61c85) will decrease coverage by 7.80%.
The diff coverage is 2.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
- Coverage   82.98%   75.19%   -7.80%     
==========================================
  Files          40       41       +1     
  Lines        3668     4056     +388     
==========================================
+ Hits         3044     3050       +6     
- Misses        512      893     +381     
- Partials      112      113       +1     
Files Coverage Δ
entity/schema.go 91.25% <57.14%> (-2.90%) ⬇️
entity/columns.go 51.58% <0.00%> (-12.14%) ⬇️
entity/columns_array_gen.go 0.00% <0.00%> (ø)

@mergify mergify bot added the ci-passed auto merge needed label label Oct 25, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Oct 26, 2023
@sre-ci-robot sre-ci-robot merged commit e2a9310 into milvus-io:master Oct 26, 2023
6 checks passed
ThreadDao pushed a commit to ThreadDao/milvus-sdk-go that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants