-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SearchByPks (work in progress) #600
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: unfode The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @unfode! It looks like this is your first PR to milvus-io/milvus-sdk-go 🎉 |
da221f8
to
6bae0f3
Compare
Signed-off-by: unfode <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
==========================================
- Coverage 82.85% 81.90% -0.96%
==========================================
Files 40 40
Lines 3640 3681 +41
==========================================
- Hits 3016 3015 -1
- Misses 512 555 +43
+ Partials 112 111 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @congqixia |
Implement SearchByPks in Go SDK corresponding to the newly added SearchByPks endpoint in Milvus (milvus-io/milvus#25882)