Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fieldName in index #570

Closed
wants to merge 1 commit into from
Closed

Conversation

wayblink
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Aug 30, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wayblink
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Aug 30, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #570 (1672c51) into master (18efb15) will increase coverage by 7.37%.
The diff coverage is 90.47%.

❗ Current head 1672c51 differs from pull request most recent head 8f26de9. Consider uploading reports for the commit 8f26de9 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
+ Coverage   75.19%   82.57%   +7.37%     
==========================================
  Files          41       40       -1     
  Lines        4056     3672     -384     
==========================================
- Hits         3050     3032      -18     
+ Misses        893      526     -367     
- Partials      113      114       +1     
Files Coverage Δ
client/collection.go 88.58% <100.00%> (ø)
client/index.go 78.29% <100.00%> (+0.69%) ⬆️
entity/indexes_search_param_gen.go 98.34% <ø> (ø)
entity/index.go 95.45% <75.00%> (-4.55%) ⬇️
entity/indexes_gen.go 94.68% <90.71%> (-4.58%) ⬇️

... and 8 files with indirect coverage changes

@mergify mergify bot added the ci-passed auto merge needed label label Sep 15, 2023
Signed-off-by: wayblink <[email protected]>
@mergify mergify bot removed the ci-passed auto merge needed label label Nov 1, 2023
@wayblink wayblink closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Changes related to something improve, likes ut and code refactor size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants