enhance: [backport] Move collection meta check to server side (#835) (#…

…842) Backport from v2.4.x pr: #835 Move collection/partition validation logic to server side in case of frequent check rpc. Signed-off-by: Congqi Xia <[email protected]>
milvus-io · Nov 7, 2024 · c82d902 · c82d902
1 parent 075335f
commit c82d902
Show file tree

Hide file tree

Showing 20 changed files with 757 additions and 770 deletions.
diff --git a/client/collection.go b/client/collection.go
@@ -301,9 +301,6 @@ func (c *GrpcClient) DropCollection(ctx context.Context, collName string, opts .
 	if c.Service == nil {
 		return ErrClientNotReady
 	}
-	if err := c.checkCollectionExists(ctx, collName); err != nil {
-		return err
-	}
 
 	req := &milvuspb.DropCollectionRequest{
 		CollectionName: collName,
@@ -350,10 +347,6 @@ func (c *GrpcClient) GetCollectionStatistics(ctx context.Context, collName strin
 		return nil, ErrClientNotReady
 	}
 
-	if err := c.checkCollectionExists(ctx, collName); err != nil {
-		return nil, err
-	}
-
 	req := &milvuspb.GetCollectionStatisticsRequest{
 		CollectionName: collName,
 	}
@@ -372,9 +365,6 @@ func (c *GrpcClient) ShowCollection(ctx context.Context, collName string) (*enti
 	if c.Service == nil {
 		return nil, ErrClientNotReady
 	}
-	if err := c.checkCollectionExists(ctx, collName); err != nil {
-		return nil, err
-	}
 
 	req := &milvuspb.ShowCollectionsRequest{
 		Type:            milvuspb.ShowType_InMemory,
@@ -404,10 +394,6 @@ func (c *GrpcClient) RenameCollection(ctx context.Context, collName, newName str
 		return ErrClientNotReady
 	}
 
-	if err := c.checkCollectionExists(ctx, collName); err != nil {
-		return err
-	}
-
 	req := &milvuspb.RenameCollectionRequest{
 		OldName: collName,
 		NewName: newName,
@@ -425,10 +411,6 @@ func (c *GrpcClient) LoadCollection(ctx context.Context, collName string, async
 		return ErrClientNotReady
 	}
 
-	if err := c.checkCollectionExists(ctx, collName); err != nil {
-		return err
-	}
-
 	req := &milvuspb.LoadCollectionRequest{
 		CollectionName: collName,
 	}
@@ -471,9 +453,6 @@ func (c *GrpcClient) ReleaseCollection(ctx context.Context, collName string, opt
 	if c.Service == nil {
 		return ErrClientNotReady
 	}
-	if err := c.checkCollectionExists(ctx, collName); err != nil {
-		return err
-	}
 
 	req := &milvuspb.ReleaseCollectionRequest{
 		DbName:         "", // reserved
@@ -537,9 +516,6 @@ func (c *GrpcClient) GetLoadingProgress(ctx context.Context, collName string, pa
 	if c.Service == nil {
 		return 0, ErrClientNotReady
 	}
-	if err := c.checkCollectionExists(ctx, collName); err != nil {
-		return 0, err
-	}
 
 	req := &milvuspb.GetLoadingProgressRequest{
 		CollectionName: collName,
@@ -558,9 +534,6 @@ func (c *GrpcClient) GetLoadState(ctx context.Context, collName string, partitio
 	if c.Service == nil {
 		return 0, ErrClientNotReady
 	}
-	if err := c.checkCollectionExists(ctx, collName); err != nil {
-		return 0, err
-	}
 
 	req := &milvuspb.GetLoadStateRequest{
 		CollectionName: collName,
@@ -579,9 +552,6 @@ func (c *GrpcClient) AlterCollection(ctx context.Context, collName string, attrs
 	if c.Service == nil {
 		return ErrClientNotReady
 	}
-	if err := c.checkCollectionExists(ctx, collName); err != nil {
-		return err
-	}
 
 	if len(attrs) == 0 {
 		return errors.New("no collection attribute provided")