Fix QueryByPKs composes wrong expr when pk data has spaces

Signed-off-by: Congqi Xia <[email protected]>
milvus-io · Nov 8, 2023 · 95990bf · 95990bf
1 parent 79dc722
commit 95990bf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/client/data.go b/client/data.go
@@ -183,11 +183,11 @@ func PKs2Expr(backName string, ids entity.Column) string {
 	case entity.FieldTypeInt64:
 		expr = fmt.Sprintf("%s in %s", pkName, strings.Join(strings.Fields(fmt.Sprint(ids.FieldData().GetScalars().GetLongData().GetData())), ","))
 	case entity.FieldTypeVarChar:
-		data := ids.FieldData().GetScalars().GetData().(*schemapb.ScalarField_StringData).StringData.Data
+		data := ids.FieldData().GetScalars().GetData().(*schemapb.ScalarField_StringData).StringData.GetData()
 		for i := range data {
 			data[i] = fmt.Sprintf("\"%s\"", data[i])
 		}
-		expr = fmt.Sprintf("%s in %s", pkName, strings.Join(strings.Fields(fmt.Sprint(data)), ","))
+		expr = fmt.Sprintf("%s in [%s]", pkName, strings.Join(data, ","))
 	}
 	return expr
 }

diff --git a/test/testcases/upsert_test.go b/test/testcases/upsert_test.go
@@ -120,7 +120,6 @@ func TestUpsertAutoID(t *testing.T) {
 }
 
 func TestUpsertVarcharPk(t *testing.T) {
-	t.Skip("https://github.com/milvus-io/milvus-sdk-go/issues/612")
 	/*
 		test upsert varchar pks
 		upsert after query