enhance: AlterIndex support delete property #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @JsDove! It looks like this is your first PR to milvus-io/milvus-proto 🎉 |
|
@JsDove Please associate the related issue to the body of your Pull Request. (eg. “issue: #6534”) |
mergify
bot
added
needs-dco
Signed-off-by: Xianhui.Lin <[email protected]>
JsDove
force-pushed
the
support_alterindex
branch
from
94395e7 to
04b35f2
Compare
mergify
bot
added
dco-passed
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, JsDove The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
can we just copy the full properties every time instead of delete and add incremental data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify API: modify AlterCollection to support alter index delete property
issuse: #338