-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Enable prefer node lables in resource group #328
Conversation
822a966
to
6ef46f9
Compare
/lgtm |
add prefer node labels in resource groups, so resource group will prefer to accept some node with given label. Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
f06e714
to
b847e1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node label selector has only key value pairs, which means only equal
operator is supported. Do we need operator to support "not equal", "in", "not in", etc?
resource group only need label set selector for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* enhance: Enable prefer node lables in resource group add prefer node labels in resource groups, so resource group will prefer to accept some node with given label. Signed-off-by: Wei Liu <[email protected]> * support node label format with key value pair Signed-off-by: Wei Liu <[email protected]> * refine node label filter name Signed-off-by: Wei Liu <[email protected]> --------- Signed-off-by: Wei Liu <[email protected]>
* enhance: Enable prefer node lables in resource group add prefer node labels in resource groups, so resource group will prefer to accept some node with given label. * support node label format with key value pair * refine node label filter name --------- Signed-off-by: Wei Liu <[email protected]>
issue: milvus-io/milvus#36977
add prefer node labels in resource groups, so resource group will prefer to accept some node with given label.