Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add openai embedding function type #323

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

junjiejiangjjj
Copy link
Contributor

@junjiejiangjjj junjiejiangjjj commented Sep 24, 2024

@sre-ci-robot sre-ci-robot requested review from czs007 and yhmo September 24, 2024 03:38
@sre-ci-robot
Copy link

Welcome @junjiejiangjjj! It looks like this is your first PR to milvus-io/milvus-proto 🎉

@mergify mergify bot added the dco-passed DCO check passed. label Sep 24, 2024
Copy link

mergify bot commented Sep 24, 2024

@junjiejiangjjj Please associate the related issue to the body of your Pull Request. (eg. “issue: #6534”)

@junjiejiangjjj
Copy link
Contributor Author

/assign @yhmo

@yhmo
Copy link
Collaborator

yhmo commented Oct 8, 2024

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: junjiejiangjjj, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Oct 8, 2024
@sre-ci-robot sre-ci-robot merged commit 85ccff4 into milvus-io:master Oct 8, 2024
4 checks passed
@junjiejiangjjj junjiejiangjjj deleted the openai_func branch November 4, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants