Skip to content

Commit

Permalink
Merge pull request #18 from zc277584121/main
Browse files Browse the repository at this point in the history
update starting milvus way in test workflow
  • Loading branch information
jaelgu authored Apr 3, 2024
2 parents 075d05b + 4ec1eec commit 3201558
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:
- "src/**"
- "tests/**"
- pyproject.toml
- .github/workflows/test.yml

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Expand Down Expand Up @@ -36,8 +37,8 @@ jobs:

- name: Run Milvus
run: |
wget https://github.com/milvus-io/milvus/releases/download/v2.4.0-rc.1/milvus-standalone-docker-compose.yml -O docker-compose.yml
sudo docker compose up -d
wget https://raw.githubusercontent.com/milvus-io/milvus/master/scripts/standalone_embed.sh
bash standalone_embed.sh start
sleep 5
echo "\nMilvus server started!"
Expand All @@ -46,5 +47,5 @@ jobs:

- name: Stop and Remove Milvus
run: |
sudo docker compose down
bash standalone_embed.sh stop
echo "\nMilvus server stopped and removed!"
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ First, to start up a Milvus service, follow
the ['Start Milvus'](https://milvus.io/docs/install_standalone-docker.md#Start-Milvus) instructions in the
documentation.

Then, to use the `MilvusDocumentStore` in a Haystack pipeline"
Then, to use the `MilvusDocumentStore` in a Haystack pipeline

```python
from haystack import Document
Expand Down

0 comments on commit 3201558

Please sign in to comment.