-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: pressing
tab in yazi jumps to dir of next open split (#232)
This feature is only supported for the latest yazi version. For now,
you have to compile yazi from source to be able to use it. See the
readme for instructions on how to do this.
If you have files open in split windows in Neovim, and have started
yazi, you can now press the `tab` key to make yazi jump to the directory
of the next open buffer. This is useful when you have multiple files
open in different directories and want to quickly jump between them.
Right now this has the following limitation: it can only jump to the
directory of the next open buffer, but not necessarily focus the buffer
in yazi. This is because yazi doesn't have a built-in way to jump to a
specific file, only a directory. This is something that might be
improved in the future.- Loading branch information
1 parent
6f3c5f2
commit 3cbc40c
Showing
21 changed files
with
331 additions
and
97 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
119 changes: 119 additions & 0 deletions
119
integration-tests/cypress/e2e/using-ya-to-read-events/cd-to-buffer.cy.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,119 @@ | ||
| import { isHovered, isNotHovered } from "./hover-utils" | ||
| import { startNeovimWithYa } from "./startNeovimWithYa" | ||
|
|
||
| // NOTE: cypress doesn't support the tab key, but control+i seems to work fine | ||
| // https://docs.cypress.io/api/commands/type#Typing-tab-key-does-not-work | ||
|
|
||
| // TODO make this more robust once we can jump to a file, not just a | ||
| // directory - could test with directories that have multiple files | ||
|
|
||
| describe("'cd' to another buffer's directory", () => { | ||
| beforeEach(() => { | ||
| cy.visit("http://localhost:5173") | ||
| }) | ||
|
|
||
| it("can highlight the buffer when hovered", () => { | ||
| const view = { | ||
| leftFile: { text: "This is other-sub-file.txt" }, | ||
| centerFile: { text: "this file is adjacent-file.txt" }, | ||
| rightFile: { text: "ello from the subdirectory!" }, | ||
| } as const | ||
|
|
||
| startNeovimWithYa({ | ||
| filename: { | ||
| openInVerticalSplits: [ | ||
| "subdirectory/subdirectory-file.txt", | ||
| "routes/posts.$postId/adjacent-file.txt", | ||
| "other-subdirectory/other-sub-file.txt", | ||
| ], | ||
| }, | ||
| startupScriptModifications: [ | ||
| "modify_yazi_config_and_add_hovered_buffer_background.lua", | ||
| ], | ||
| }).then(() => { | ||
| // sanity check to make sure the files are open | ||
| cy.contains(view.leftFile.text) | ||
| cy.contains(view.centerFile.text) | ||
| cy.contains(view.rightFile.text) | ||
|
|
||
| // before doing anything, both files should be unhovered (have the | ||
| // default background color) | ||
| isNotHovered(view.leftFile.text) | ||
| isNotHovered(view.centerFile.text) | ||
| isNotHovered(view.rightFile.text) | ||
|
|
||
| // start yazi | ||
| cy.typeIntoTerminal("{upArrow}") | ||
|
|
||
| // Switch to the other buffers' directories in yazi. This should make | ||
| // yazi send a hover event for the new, highlighted file. | ||
| // | ||
| // Since each directory only has one file, it should be highlighted :) | ||
| cy.typeIntoTerminal("{control+i}") | ||
| isNotHovered(view.leftFile.text) | ||
| isHovered(view.centerFile.text) | ||
| isNotHovered(view.rightFile.text) | ||
|
|
||
| cy.typeIntoTerminal("{control+i}") | ||
| isHovered(view.leftFile.text) | ||
| isNotHovered(view.centerFile.text) | ||
| isNotHovered(view.rightFile.text) | ||
|
|
||
| cy.typeIntoTerminal("{control+i}") | ||
| isNotHovered(view.leftFile.text) | ||
| isNotHovered(view.centerFile.text) | ||
| isHovered(view.rightFile.text) | ||
|
|
||
| // tab once more to make sure it wraps around | ||
| cy.typeIntoTerminal("{control+i}") | ||
| isNotHovered(view.leftFile.text) | ||
| isHovered(view.centerFile.text) | ||
| isNotHovered(view.rightFile.text) | ||
| }) | ||
| }) | ||
|
|
||
| it("skips highlighting splits for the same file", () => { | ||
| const view = { | ||
| leftAndCenterFile: { text: "ello from the subdirectory!" }, | ||
| rightFile: { text: "This is other-sub-file.txt" }, | ||
| } as const | ||
|
|
||
| startNeovimWithYa({ | ||
| filename: { | ||
| openInVerticalSplits: [ | ||
| // open the same file in two splits | ||
| "subdirectory/subdirectory-file.txt", | ||
| "subdirectory/subdirectory-file.txt", | ||
| "other-subdirectory/other-sub-file.txt", | ||
| ], | ||
| }, | ||
| startupScriptModifications: [ | ||
| "modify_yazi_config_and_add_hovered_buffer_background.lua", | ||
| ], | ||
| }).then(() => { | ||
| isNotHovered(view.leftAndCenterFile.text) | ||
| isNotHovered(view.rightFile.text) | ||
|
|
||
| // start yazi | ||
| cy.typeIntoTerminal("{upArrow}") | ||
|
|
||
| cy.typeIntoTerminal("{control+i}") | ||
|
|
||
| // the right file should be highlighted | ||
| isNotHovered(view.leftAndCenterFile.text) | ||
| isHovered(view.rightFile.text) | ||
|
|
||
| // tab again to make sure it wraps around. It should highlight both splits | ||
| cy.typeIntoTerminal("{control+i}") | ||
| isHovered(view.leftAndCenterFile.text) | ||
| isNotHovered(view.rightFile.text) | ||
|
|
||
| // tab again. Since the left and center file are the same, it should | ||
| // skip the center file and highlight the right file | ||
|
|
||
| cy.typeIntoTerminal("{control+i}") | ||
| isNotHovered(view.leftAndCenterFile.text) | ||
| isHovered(view.rightFile.text) | ||
| }) | ||
| }) | ||
| }) |
Oops, something went wrong.