-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for tracker URLs inside mihon #469
Open
Shamicen
wants to merge
13
commits into
mihonapp:main
Choose a base branch
from
Shamicen:manga_url_field
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracker is one thing but like only 2 site I know include those, Not really interested in other web links. |
OK I'll change it to only display tracker links. |
Done |
Shamicen
changed the title
Support for tracker and other website URLs inside mihon.
Support for tracker URLs inside mihon
Mar 11, 2024
Can you extract the non-ui bit on a separate pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a field for website URLs.
Features:
Users can open a tracker-links manga inside the Mihon tracker search by pressing "Open in Mihon:
(Only logged in trackers have this option)
New custom icons for every external tracker:
Other
Chip
.Http-Source
manga. I would like some feedback about the best place to do this.Kitsu
andMangaUpdates
do not have the manga id in their tracker URLs, so I'm only performing a normal search at the moment.Icons
I used the program mentioned in
CustomIcons.kt
(https://github.com/DevSrSouza/svg-to-compose) to turn the svg files into Kotlin codeThe icons are from the following sources:
MyAnimeList: (CC0 License) https://icon-icons.com/icon/myanimelist-logo/248409
Anilist: (CC0 License) https://www.svgrepo.com/svg/329929/anilist
Kitsu: (CC0 License) https://www.svgrepo.com/svg/330791/kitsu
Shikimori: (CC0 License) https://www.svgrepo.com/svg/306721/shikimori
MangaUpdates: I used the image inside
res/drawable-nodpi/
and made a svg from it.Bangumi: I used the image inside
res/drawable-nodpi/
and made a svg from it.All external Icons are licensed under CC0