Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a setting for users to lower the threshold for HW bitmaps #1486

Closed
wants to merge 4 commits into from
Closed

Add a setting for users to lower the threshold for HW bitmaps #1486

wants to merge 4 commits into from

Commits on Nov 20, 2024

  1. - Add an option to only skip hwBitmap when it could cause empty textures 

    Debugging shows images may have bigger dimensions than expected. To avoid exceeding maxTextureSize, a second optional check is added, controlled by a toggle under Advanced Settings.
    @Raikuha
    Raikuha committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    38e639a View commit details
    Browse the repository at this point in the history

  2. Deem images safe if they're within the view dimensions 

    Some pages present flickering due to having dimensions that surpass those calculated in SubsamplingScaleImageView.
    @Raikuha
    Raikuha committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    6ea0a20 View commit details
    Browse the repository at this point in the history

  3. - Made maxBitmapSize setting into a user-defined restriction 

    Rather than a toggle and test-based guesses, now the fix relies on user input to handle the images that don't work normally
    @Raikuha
    Raikuha committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    11e6507 View commit details
    Browse the repository at this point in the history

  4. Changed bitmapMaxSize input to use a slider 

    Range is maxTextureSize/2 .. maxTextureSize, set to 5 steps in SettingsAdvancedScreen
    @Raikuha
    Raikuha committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e5cd22a View commit details
    Browse the repository at this point in the history