Add FOSS flavor #1448
Add FOSS flavor #1448
Conversation
.github/workflows/build_push.yml
Outdated
| @@ -93,6 +106,10 @@ jobs: | |||
| sha=`sha256sum mihon-x86_64-${{ env.VERSION_TAG }}.apk | awk '{ print $1 }'` | |||
| echo "APK_X86_64_SHA=$sha" >> $GITHUB_ENV | |||
|
|
|||
| mv app/build/outputs/apk/foss/release/app-foss-universal-release-unsigned-signed.apk mihon-${{ env.VERSION_TAG }}.apk | |||
There was a problem hiding this comment.
| mv app/build/outputs/apk/foss/release/app-foss-universal-release-unsigned-signed.apk mihon-${{ env.VERSION_TAG }}.apk | |
| mv app/build/outputs/apk/foss/release/app-foss-universal-release-unsigned-signed.apk mihon-foss-${{ env.VERSION_TAG }}.apk |
There was a problem hiding this comment.
Btw, why do you use mv for universal build and cp for ABIs?
|
FOSS build setup can exist for F-Droid but I don't necessarily see a point of having them on GitHub. |
The point of having them on GitHub is to allow reproducible builds. Basically, you build and sign the release with your key, and F-Droid compares it with their own build. If they match, they will publish your release with your key. This makes the release process safer by making the developer sign the releases (and not F-Droid), while allowing F-Droid to still check for any tampering attempt. Also:
|
|
FOSS builds can stay in a separate repo then similar to preview/beta |
|
Good idea! Should I revert the changes from the |
app/src/main/java/eu/kanade/presentation/more/onboarding/PermissionStep.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsSecurityScreen.kt
Outdated
Show resolved
Hide resolved
| @@ -45,6 +45,8 @@ class AppUpdateChecker { | |||
| val GITHUB_REPO: String by lazy { | |||
| if (BuildConfig.PREVIEW) { | |||
| "mihonapp/mihon-preview" | |||
| } else if (BuildConfig.FLAVOR == "foss") { | |||
| "mihonapp/mihon-foss" | |||
There was a problem hiding this comment.
@AntsyLich Let me know if I need to change the repo name
This PR implements a FOSS flavor (i.e. with no proprietary dependencies) and builds it when a new version is tagged.
It's a pre-requisite for #1 although publishing it on F-Droid is not mandatory (some users may want to use the FOSS flavor with the internal updater, or something else like Obtainium). Note that compared to Tachiyomi, the updater can be left enabled this time, if you choose to make reproducible builds (which is the recommended way to publish on F-Droid).
Notes: