Update composer, style

mihkelallorg · Mar 6, 2019 · ec5fdb0 · ec5fdb0
1 parent 22c18f6
commit ec5fdb0
Show file tree

Hide file tree

Showing 10 changed files with 34 additions and 32 deletions.
diff --git a/composer.json b/composer.json
@@ -5,7 +5,7 @@
     "require": {
         "google/cloud-translate": "^1.2",
         "php": ">=7.1.3",
-        "illuminate/support": "5.6.*|5.7.*"
+        "illuminate/support": "5.6.*|5.7.*|5.8.*"
     },
     "require-dev": {
         "matthewbdaly/artisan-standalone": "0.0.*",
@@ -25,9 +25,9 @@
         }
     },
     "autoload-dev": {
-        "classmap": [
-            "tests"
-        ]
+        "psr-4": {
+            "Mihkullorg\\Tests\\Translatable\\": "tests/"
+        }
     },
     "extra": {
         "laravel": {

diff --git a/src/Models/Translation.php b/src/Models/Translation.php
@@ -39,6 +39,7 @@ public function scopeLanguage($query, $language)
     public function scopeFresherThan($query, $date)
     {
         $date = $date instanceof Carbon ? $date->toDateTimeString() : $date;
+
         return $query->where('updated_at', '>=', $date);
     }
 

diff --git a/src/Traits/Translatable.php b/src/Traits/Translatable.php
@@ -1,16 +1,16 @@
 <?php
 
-namespace Mihkullorg\Translatable;
+namespace Mihkullorg\Translatable\Traits;
 
-use Illuminate\Database\Eloquent\Relations\MorphMany;
 use Mihkullorg\Translatable\Facades\Translator;
 use Mihkullorg\Translatable\Models\Translation;
+use Illuminate\Database\Eloquent\Relations\MorphMany;
 
 trait Translatable
 {
     public function translate($field, $language, $translation = null)
     {
-        if (!$translation) {
+        if (! $translation) {
             $translation = Translator::translate($this->$field, $language);
         }
 
@@ -45,7 +45,7 @@ public function translations()
     /**
      * @param string $field Translatable field name
      * @param string $language Language code
-     * @return integer
+     * @return int
      */
     public function deleteTranslation($field, $language)
     {
@@ -79,14 +79,18 @@ public function createTranslation($field, $language, $translation)
      *      'language' => 'ru',
      *      'body' => 'Russian body translations',
      *      'title' => '...',
-     * ]
+     * ].
      *
      * @return array[]
      */
     public function getTranslationsAsArray()
     {
         return $this->translations->groupBy('language')->map(function($language) {
-            return $language->groupBy('field')->map(function($field) { return $field->first()->value; });
-        })->each(function($values, $language) { $values->put('language', $language); })->values()->toArray();
+            return $language->groupBy('field')->map(function($field) {
+                return $field->first()->value;
+            });
+        })->each(function($values, $language) {
+            $values->put('language', $language);
+        })->values()->toArray();
     }
 }
diff --git a/src/TranslatableServiceProvider.php b/src/TranslatableServiceProvider.php
@@ -13,7 +13,7 @@ class TranslatableServiceProvider extends BaseServiceProvider
      */
     public function boot()
     {
-        $this->loadMigrationsFrom(__DIR__ . '/database/migrations');
+        $this->loadMigrationsFrom(__DIR__.'/database/migrations');
         $this->publishConfig();
         $this->app->singleton('mt-translator', function ($app) {
             return new TranslatorManager($app);
@@ -32,13 +32,13 @@ public function register()
 
     private function publishConfig()
     {
-        $config = __DIR__ . '/../config/config.php';
+        $config = __DIR__.'/../config/config.php';
         $migrationFileName = '2019_01_10_000001_create_translatable_tables.php';
-        $migration = __DIR__ . '/database/migrations/' . $migrationFileName;
+        $migration = __DIR__.'/database/migrations/'.$migrationFileName;
 
         $this->publishes([
             $config => config_path('translatable.php'),
-            $migration => app_path('database/migrations/' . $migrationFileName),
+            $migration => app_path('database/migrations/'.$migrationFileName),
         ], 'translatable');
     }
 }
diff --git a/src/TranslatorManager.php b/src/TranslatorManager.php
@@ -3,12 +3,11 @@
 namespace Mihkullorg\Translatable;
 
 use Illuminate\Support\Manager;
-use Mihkullorg\Translatable\Contracts\TranslatorInterface;
 use Mihkullorg\Translatable\Drivers\GoogleTranslator;
+use Mihkullorg\Translatable\Contracts\TranslatorInterface;
 
 class TranslatorManager extends Manager implements TranslatorInterface
 {
-
     /**
      * Get the default driver name.
      *

diff --git a/tests/CreatesApplication.php b/tests/CreatesApplication.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Tests;
+namespace Mihkullorg\Tests\Translatable;
 
 use Hash;
 
@@ -20,7 +20,7 @@ protected function getEnvironmentSetup($app)
     {
     }
 
-    public function setUp()
+    protected function setUp(): void
     {
         parent::setUp();
 

diff --git a/tests/Models/TestModel.php b/tests/Models/TestModel.php
@@ -1,9 +1,9 @@
 <?php
 
-namespace Mihkullorg\Translatable\Tests\Models;
+namespace Mihkullorg\Tests\Translatable\Models;
 
 use Illuminate\Database\Eloquent\Model;
-use Mihkullorg\Translatable\Translatable;
+use Mihkullorg\Translatable\Traits\Translatable;
 
 class TestModel extends Model
 {

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -1,6 +1,6 @@
 <?php
 
-namespace Tests;
+namespace Mihkullorg\Tests\Translatable;
 
 use Orchestra\Testbench\TestCase as BaseTestCase;
 use Mockery\Adapter\Phpunit\MockeryPHPUnitIntegration;

diff --git a/tests/TranslatableTest.php b/tests/TranslatableTest.php
@@ -1,17 +1,13 @@
 <?php
 
+namespace Mihkullorg\Tests\Translatable;
+
 use Carbon\Carbon;
+use Mihkullorg\Tests\Translatable\Models\TestModel;
 use Mihkullorg\Translatable\Facades\Translator;
-use Mihkullorg\Translatable\Tests\Models\TestModel;
-use Tests\TestCase;
 
 class TranslatableTest extends TestCase
 {
-    public function setUp()
-    {
-        parent::setUp();
-    }
-
     public function test_translating_model_field_manually()
     {
         /** @var TestModel $model */
@@ -41,8 +37,8 @@ public function test_translating_model_field_with_translator()
     }
 
     /**
-     * Old translation should be deleted
-     * New translation should be created with Translator
+     * Old translation should be deleted.
+     * New translation should be created with Translator.
      */
     public function test_translating_an_updated_model()
     {
@@ -105,6 +101,7 @@ private function assertTranslationExists(TestModel $model, $field, $language, $v
             'value' => $value,
         ]);
     }
+
     /**
      * @param TestModel $model
      * @param $field
@@ -127,6 +124,7 @@ private function createTranslationInThePast(TestModel $model, $field, $language,
         $translation = $model->translations()->make(compact('field', 'language', 'value'));
         $translation->updated_at = Carbon::now()->subDay();
         $translation->save(['timestamps' => false]);
+
         return $translation;
     }
 }
diff --git a/tests/factories/TestModelFactory.php b/tests/factories/TestModelFactory.php
@@ -1,7 +1,7 @@
 <?php
 
 use Faker\Generator as Faker;
-use Mihkullorg\Translatable\Tests\Models\TestModel;
+use Mihkullorg\Tests\Translatable\Models\TestModel;
 
 /*
 |--------------------------------------------------------------------------
-Original file line number
+Diff line change
@@ Expand Up / @@ -39,6 +39,7 @@ public function scopeLanguage($query, $language) @@
         public function scopeFresherThan($query, $date)
         {
             $date = $date instanceof Carbon ? $date->toDateTimeString() : $date;
             return $query->where('updated_at', '>=', $date);
         }
@@ Expand Down @@