fix: using absolute paths for tsc.cmd on Windows #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the issue with using absolute paths for `tsc.cmd` on Windows and add a test to verify the change. * **lib/process.js** - Update the `spawn` function to use absolute paths for `tsc.cmd` on Windows. - Check for `tsc.cmd` under `node_modules/.bin` and use this path if it exists, otherwise use the global `tsc.cmd`. * **test/index.test.js** - Add a test to check the `tsc` version and ensure it matches the version in `node_modules/typescript/package.json`. * **History.md** - Add a new entry for the fix of using absolute paths for `tsc.cmd` on Windows. * **.github/workflows/nodejs.yml** - Add a global TypeScript installation with a specific version. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/midwayjs/mwtsc?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue #29 with using absolute paths for
tsc.cmdon Windows and add a test to verify the change.lib/process.js
spawnfunction to use absolute paths fortsc.cmdon Windows.tsc.cmdundernode_modules/.binand use this path if it exists, otherwise use the globaltsc.cmd.test/index.test.js
tscversion and ensure it matches the version innode_modules/typescript/package.json.History.md
tsc.cmdon Windows..github/workflows/nodejs.yml
For more details, open the Copilot Workspace session.