#47: Don't duplicate properties being passed to the parent class.

middlebury · Nov 25, 2024 · f4a4f51 · f4a4f51
1 parent 3fdd493
commit f4a4f51
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/Service/CatalogSync/Syncer/OciSyncer.php b/src/Service/CatalogSync/Syncer/OciSyncer.php
@@ -25,8 +25,8 @@ class OciSyncer extends AbstractSyncer implements Syncer
 {
     public function __construct(
         protected OciSourceDatabase $source_db,
-        protected PdoDestinationDatabase $destination_db,
-        protected array $allowedBlckCodes = [],
+        PdoDestinationDatabase $destination_db,
+        array $allowedBlckCodes = [],
     ) {
         parent::__construct($destination_db, $allowedBlckCodes);
 

diff --git a/src/Service/CatalogSync/Syncer/OciWithCacheSyncer.php b/src/Service/CatalogSync/Syncer/OciWithCacheSyncer.php
@@ -26,10 +26,10 @@
 class OciWithCacheSyncer extends OciSyncer implements Syncer
 {
     public function __construct(
-        protected OciSourceDatabase $source_db,
-        protected PdoDestinationDatabase $destination_db,
+        OciSourceDatabase $source_db,
+        PdoDestinationDatabase $destination_db,
         protected PdoDestinationDatabase $temp_db,
-        protected array $allowedBlckCodes = [],
+        array $allowedBlckCodes = [],
         private string $mysqlCommand = 'mysql',
         private string $mysqldumpCommand = 'mysqldump',
     ) {

diff --git a/src/Service/CatalogSync/Syncer/PdoMysqlSyncer.php b/src/Service/CatalogSync/Syncer/PdoMysqlSyncer.php
@@ -26,8 +26,8 @@ class PdoMysqlSyncer extends AbstractSyncer implements Syncer
 {
     public function __construct(
         protected PdoMysqlSourceDatabase $source_db,
-        protected PdoDestinationDatabase $destination_db,
-        protected array $allowedBlckCodes = [],
+        PdoDestinationDatabase $destination_db,
+        array $allowedBlckCodes = [],
     ) {
         parent::__construct($destination_db, $allowedBlckCodes);
     }